gortiz commented on code in PR #10465:
URL: https://github.com/apache/pinot/pull/10465#discussion_r1147212250
##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ExecutionStats.java:
##########
@@ -115,20 +113,6 @@ public long getTimeUsedMs() {
@Override
public String toString() {
- Map<String, Object> map = new HashMap<>();
- map.put(NUM_SERVERS_QUERIED, getNumServersQueried());
- map.put(NUM_SERVERS_RESPONDED, getNumServersResponded());
- map.put(NUM_DOCS_SCANNED, getNumDocsScanned());
- map.put(NUM_ENTRIES_SCANNED_IN_FILTER, getNumEntriesScannedInFilter());
- map.put(NUM_ENTRIES_SCANNED_POST_FILTER, getNumEntriesScannedPostFilter());
- map.put(NUM_SEGMENTS_QUERIED, getNumSegmentsQueried());
- map.put(NUM_SEGMENTS_PROCESSED, getNumSegmentsProcessed());
- map.put(NUM_SEGMENTS_MATCHED, getNumSegmentsMatched());
- map.put(NUM_CONSUMING_SEGMENTS_QUERIED, getNumConsumingSegmentsQueried());
- map.put(MIN_CONSUMING_FRESHNESS_TIME_MS, getMinConsumingFreshnessTimeMs()
+ "ms");
- map.put(TOTAL_DOCS, getTotalDocs());
- map.put(NUM_GROUPS_LIMIT_REACHED, isNumGroupsLimitReached());
- map.put(TIME_USED_MS, getTimeUsedMs() + "ms");
- return map.toString();
+ return _brokerResponse.toString();
Review Comment:
Good point @swaminathanmanish. The change is simple, but maybe there was a
reason to do not include something? Doesn't seem a security concern given the
nature of the object, but it would be great to have a verification. @KKcorps
@kishoreg @npawar were the ones involved in the first PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
