swaminathanmanish commented on code in PR #10484:
URL: https://github.com/apache/pinot/pull/10484#discussion_r1149700724
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/TableConfigBuilder.java:
##########
@@ -256,6 +258,16 @@ public TableConfigBuilder
setInvertedIndexColumns(List<String> invertedIndexColu
return this;
}
+ public TableConfigBuilder setOptimizeDictionaryForMetrics(boolean
optimizeDictionaryForMetrics) {
+ _optimizeDictionaryForMetrics = optimizeDictionaryForMetrics;
+ return this;
+ }
+
+ public TableConfigBuilder setNoDictionarySizeRatioThreshold(double
noDictionarySizeRatioThreshold) {
Review Comment:
Im following what we introduced in the tableIndexConfig, to keep it
consistent :).
From this doc -
https://docs.pinot.apache.org/configuration-reference/table#table-index-config
"If optimizeDictionaryForMetrics enabled, dictionary is not created for the
metric columns for which noDictionaryIndexSize/ indexWithDictionarySize is less
than the noDictionarySizeRatioThreshold
Default: 0.85"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
