jugomezv commented on code in PR #10418:
URL: https://github.com/apache/pinot/pull/10418#discussion_r1149851292
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -618,14 +618,18 @@ private boolean processStreamEvents(MessageBatch
messagesAndOffsets, long idlePi
updateCurrentDocumentCountMetrics();
if (messagesAndOffsets.getUnfilteredMessageCount() > 0) {
_hasMessagesFetched = true;
+ if (messageCount == 0) {
+ // If we did not get any events but got some unfiltered messages, we
attempt to estimate the ingestion
Review Comment:
yes, there was some wording issue but now I have updated it correctly, as
for the last suggestion they are it is the same right, not sure what advantage
would be to call the method again here if we have the outcome in messageCount
other than the overhead of the call?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
