KKcorps commented on code in PR #10447:
URL: https://github.com/apache/pinot/pull/10447#discussion_r1161961765
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/QueryDispatcher.java:
##########
@@ -221,12 +223,14 @@ private static List<DataBlock>
reduceMailboxReceive(MailboxReceiveOperator mailb
OperatorStats operatorStats = entry.getValue();
ExecutionStatsAggregator rootStatsAggregator =
executionStatsAggregatorMap.get(0);
ExecutionStatsAggregator stageStatsAggregator =
executionStatsAggregatorMap.get(operatorStats.getStageId());
- if (queryPlan != null) {
- StageMetadata operatorStageMetadata =
queryPlan.getStageMetadataMap().get(operatorStats.getStageId());
- OperatorUtils.recordTableName(operatorStats,
operatorStageMetadata);
- }
rootStatsAggregator.aggregate(null,
entry.getValue().getExecutionStats(), new HashMap<>());
- stageStatsAggregator.aggregate(null,
entry.getValue().getExecutionStats(), new HashMap<>());
+ if (stageStatsAggregator != null) {
Review Comment:
Ohh because there's no possibility of them being null honestly. I just added
this cause I was planning a flow where I will not initiate StatsAggregator for
a stage where we didn't want to calculate any stats.
However, I ended up removing that flow cause we do want some stage stats
even when tracing is disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
