gortiz opened a new pull request, #10632: URL: https://github.com/apache/pinot/pull/10632
This is a bugfix. There were two situations where Dictionary was loaded offheap before index-spi was merged but loaded onheap after that. The original issue was detected by @jadami10 in https://github.com/apache/pinot/issues/10554#issuecomment-1502462531. The reason was the static final instance `DictionaryIndexConfig.DEFAULT_OFFHEAP` that was actually configured to load the index onheap. The normal `DictionaryIndexConfig.DEFAULT` is already offheap, so there is no need to have the incorrect static final. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
