walterddr commented on issue #10628:
URL: https://github.com/apache/pinot/issues/10628#issuecomment-1513523744

   ah. i think this was the issue
   ```
     LogicalFilter(condition=[IS NOT TRUE($4)])
   
   ...
               LogicalAggregate(group=[{0}], agg#0=[MIN($1)])
                 LogicalProject(userUUID=[$4], $f1=[true])
   ```
   ^ the only reason why this is generated a LEFT JOIN is to handle the 
IS_NOT_TRUE --> b/c it is utilizing the nullability of LEFT JOIN to potentially 
give the IS_NOT_TRUE function a false result -->otherwise based on the plan it 
will always be true and thus the filter is useless. 
   
   however in Pinot's use case this should actually be sufficient to use INNER 
JOIN b/c the left userUUID we can guarantee to be non-nullable (otherwise we 
can throw?) thus we don't need to handle this situation. was wondering if 
that's better.
   
   @somandal was adding the BOOL_AND and BOOL_OR resolves the issue? it is 
"one" solution but i don't think it is ideal b/c it makes several extra 
operators that does basically nothing :-/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to