shounakmk219 commented on code in PR #10623:
URL: https://github.com/apache/pinot/pull/10623#discussion_r1170891742


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/fst/FstIndexType.java:
##########
@@ -167,4 +173,10 @@ protected TextIndexReader 
createIndexReader(PinotDataBuffer dataBuffer, ColumnMe
       return createIndexReader(dataBuffer, metadata);
     }
   }
+
+  @Override
+  public void convertToNewFormat(TableConfig tableConfig, Schema schema) {
+    super.convertToNewFormat(tableConfig, schema);

Review Comment:
   I liked what @jugomezv suggested as mostly the additional override logic is 
around cleaning the old properties in table config which are specific to an 
index type. Will make the changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to