saurabhd336 commented on code in PR #10623:
URL: https://github.com/apache/pinot/pull/10623#discussion_r1172490347
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/AbstractIndexType.java:
##########
@@ -62,6 +71,39 @@ public IndexReaderFactory<IR> getReaderFactory() {
return _readerFactory;
}
+ public void convertToNewFormat(TableConfig tableConfig, Schema schema) {
+ Map<String, C> deserialize = getConfig(tableConfig, schema);
+ for (Map.Entry<String, C> entry : deserialize.entrySet()) {
+ boolean fieldConfigFound = false;
+ List<FieldConfig> fieldConfigList = tableConfig.getFieldConfigList() ==
null
Review Comment:
Seems redundant. Can we create a map<columnName, FieldConfigList> _map and
while looping over `deserialize` map, get the correct fieldConfigList for that
column?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
