walterddr commented on code in PR #10662:
URL: https://github.com/apache/pinot/pull/10662#discussion_r1173998500
##########
pinot-query-runtime/src/test/resources/queries/Comparisons.json:
##########
@@ -121,11 +121,10 @@
{ "sql": "SELECT i1 <> i2, i2 <> i1 FROM {tbl}" },
{ "sql": "SELECT i1 = i2, i2 = i1 FROM {tbl}" },
{ "sql": "SELECT i1 IS DISTINCT FROM i2, i2 IS DISTINCT FROM i1 FROM
{tbl}" },
- {
- "ignored": true,
- "comment": "fails with IllegalStateException... not sure why!",
- "sql": "SELECT * FROM {tbl} WHERE i1 >= i2"
- }
+ { "sql": "SELECT * FROM {tbl} WHERE i1 >= i2" },
Review Comment:
can you add a test when the 2 columns are from different table? e.g.
`SELECT * FROM {tbl1} JOIN {tbl2} ON xxx WHERE {tbl1}.i1 >= {tbl2}.i2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
