walterddr commented on code in PR #10671:
URL: https://github.com/apache/pinot/pull/10671#discussion_r1174455253


##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/StageMetadata.java:
##########
@@ -75,43 +73,21 @@ public void addScannedTable(String tableName) {
   // attached physical plan context.
   // -----------------------------------------------
 
-  public Map<ServerInstance, Map<String, List<String>>> 
getServerInstanceToSegmentsMap() {
-    return _serverInstanceToSegmentsMap;
-  }
-
-  public void setServerInstanceToSegmentsMap(

Review Comment:
   all setters should be moved to `DispatchablePlanContext` which gradually 
completes the stage metadata. 
   
   removing all setter makes StageMetadata immutable



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to