jonasgeiregat opened a new pull request, #10672:
URL: https://github.com/apache/pinot/pull/10672
Instructions:
1. The PR has to be tagged with at least one of the following labels (*):
1. `feature`
2. `bugfix`
2. Remove these instructions before publishing the PR.
(*) Other labels to consider:
- `testing`
- `refactor`
- `cleanup`
The general idea was to make use of the natively supported
`mixinStandardHelpOptions` of picocli.
I took the liberty to add some tests for the `PinotAdministrator`.
There are a couple of classes that still need some work but I don't know
what would be a good way to tackle it.
I'm referring to:
- `AnonymizeDataCommand`
- `RebalanceTableCommand`
- `RealtimeProvisioningHelperCommand`
All those had a `printExamples` method that is not used anymore, previously
this was added to the description when using the `-h` flag.
Now the `-h` flag has been replaced by the native impl. of picocli.
I was thinking of either looking for a way of appending it to the `-h` flag
after the native help print out of picocli
or
add another flag --usage which would simply print out everything for those
commands.
Amy feedback more then welcome I'm happy to adjust the code in order to get
it merged in and improve pinot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
