61yao commented on code in PR #10653:
URL: https://github.com/apache/pinot/pull/10653#discussion_r1176811227
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/AbstractIndexType.java:
##########
@@ -51,7 +51,11 @@ public Map<String, C> getConfig(TableConfig tableConfig,
Schema schema) {
if (_deserializer == null) {
_deserializer = createDeserializer();
}
- return _deserializer.deserialize(tableConfig, schema);
+ try {
+ return _deserializer.deserialize(tableConfig, schema);
Review Comment:
Can you help me understand why the original code doesn't have to deal with
exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
