Jackie-Jiang commented on code in PR #10681:
URL: https://github.com/apache/pinot/pull/10681#discussion_r1177104234
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/BaseMailboxReceiveOperator.java:
##########
@@ -109,19 +97,18 @@ public List<MultiStageOperator> getChildOperators() {
@Override
public void close() {
super.close();
- releaseRemainingMailboxes();
+ cancelRemainingMailboxes();
}
@Override
public void cancel(Throwable t) {
super.cancel(t);
- releaseRemainingMailboxes();
+ cancelRemainingMailboxes();
Review Comment:
Currently it is used by both `close()` and `cancel(Throwable t)`. Currently
seems I can remove the one under `close()`, but if we support any kind of early
termination in the future, `cancel` won't always be called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
