walterddr commented on code in PR #10705:
URL: https://github.com/apache/pinot/pull/10705#discussion_r1182900917
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManagerStatelessTest.java:
##########
@@ -540,6 +540,19 @@ public void testValidateTenantConfig() {
// Valid tenant config without tagOverrideConfig
_helixResourceManager.validateTableTenantConfig(offlineTableConfig);
+ // Invalid serverTag in tierConfigs
+ TierConfig tierConfig = new TierConfig("myTier",
TierFactory.TIME_SEGMENT_SELECTOR_TYPE, "10d", null,
+ TierFactory.PINOT_SERVER_STORAGE_TYPE, "Unknown_OFFLINE", null, null);
Review Comment:
add a test for null? (looks like TierConfig json property server tag is
nullable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
