61yao commented on code in PR #10598:
URL: https://github.com/apache/pinot/pull/10598#discussion_r1184563096
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CoalesceTransformFunction.java:
##########
@@ -399,4 +390,22 @@ public String[] transformToStringValuesSV(ValueBlock
valueBlock) {
}
return getStringTransformResults(valueBlock);
}
+
+ @Override
+ public RoaringBitmap getNullBitmap(ValueBlock valueBlock) {
+ RoaringBitmap[] nullBitMaps = getNullBitMaps(valueBlock,
_transformFunctions);
+ RoaringBitmap bitmap = nullBitMaps[0];
+ for (int i = 1; i < nullBitMaps.length; i++) {
+ RoaringBitmap curBitmap = nullBitMaps[i];
+ if (bitmap != null && curBitmap != null) {
+ bitmap.and(curBitmap);
+ } else {
+ bitmap = null;
Review Comment:
This doesn't belong to this PR either..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
