siddharthteotia commented on code in PR #10636:
URL: https://github.com/apache/pinot/pull/10636#discussion_r1186957640
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/AggregationFunctionType.java:
##########
@@ -94,7 +95,15 @@ public enum AggregationFunctionType {
// boolean aggregate functions
BOOLAND("boolAnd"),
- BOOLOR("boolOr");
+ BOOLOR("boolOr"),
+
+ // argMin and argMax
+ ARGMIN("argMin"),
+ ARGMAX("argMax"),
+
PINOTPARENTAGGREGATIONARGMIN(CommonConstants.RewriterConstants.PARENT_AGGREGATION_NAME_PREFIX
+ ARGMIN.getName()),
Review Comment:
(nit) Suggest removing `PINOT` from prefix to be consistent with rest of the
naming unless there is a strong reason to keep this prefix ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]