ankitsultana commented on code in PR #10725:
URL: https://github.com/apache/pinot/pull/10725#discussion_r1187746195
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/PinotFSSegmentUploader.java:
##########
@@ -96,9 +96,8 @@ public URI uploadSegment(File segmentFile, LLCSegmentName
segmentName) {
LOGGER.info("Interrupted while waiting for segment upload of {} to {}.",
segmentName, _segmentStoreUriStr);
Thread.currentThread().interrupt();
} catch (TimeoutException e) {
- _serverMetrics.addMeteredTableValue(segmentName.getTableName(),
ServerMeter.SEGMENT_UPLOAD_TIMEOUT, 1);
- LOGGER.warn("Timed out waiting to upload segment: {} for table: {}",
- segmentName.getSegmentName(), segmentName.getTableName());
+ _serverMetrics.addMeteredTableValue(rawTableName,
ServerMeter.SEGMENT_UPLOAD_TIMEOUT, 1);
Review Comment:
Yeah you are right. Done. Also added these metrics for Server2Controller
segment uploader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
