klsince commented on code in PR #10726:
URL: https://github.com/apache/pinot/pull/10726#discussion_r1199273342
##########
pinot-spi/src/main/java/org/apache/pinot/spi/env/PinotConfiguration.java:
##########
@@ -356,15 +354,7 @@ public long getProperty(String name, long defaultValue) {
* @return the property String value. Fallback to default value if missing.
*/
public String getProperty(String name, String defaultValue) {
- Object rawProperty = getRawProperty(name, defaultValue);
- if (rawProperty instanceof List) {
- return StringUtils.join(((ArrayList) rawProperty).toArray(), ',');
- } else {
- if (rawProperty == null) {
- return null;
- }
- return rawProperty.toString();
- }
+ return _configuration.getString(relaxPropertyName(name), defaultValue);
Review Comment:
If I understood that mapValue() method correctly, using `> 1` was on
purpose. Basically, if a config has multi string values, those values are
combined to a comma separated string; otherwise, return the raw property.
After discussion with @dd-willgan, I'm testing some ideas here:
https://github.com/apache/pinot/pull/10785, mainly to keep things backward
compatible as much as possible. Let's see how that one goes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
