swaminathanmanish commented on code in PR #10874:
URL: https://github.com/apache/pinot/pull/10874#discussion_r1224336596
##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentProcessorFramework.java:
##########
@@ -72,11 +74,30 @@ public SegmentProcessorFramework(List<RecordReader>
recordReaders, SegmentProces
File workingDir)
throws IOException {
Preconditions.checkState(!recordReaders.isEmpty(), "No record reader is
provided");
-
LOGGER.info("Initializing SegmentProcessorFramework with {} record
readers, config: {}, working dir: {}",
recordReaders.size(), segmentProcessorConfig,
workingDir.getAbsolutePath());
_recordReaders = recordReaders;
+ _recordReaderFileConfigs = null;
+ _segmentProcessorConfig = segmentProcessorConfig;
+
+ _mapperOutputDir = new File(workingDir, "mapper_output");
+ FileUtils.forceMkdir(_mapperOutputDir);
+ _reducerOutputDir = new File(workingDir, "reducer_output");
+ FileUtils.forceMkdir(_reducerOutputDir);
+ _segmentsOutputDir = new File(workingDir, "segments_output");
+ FileUtils.forceMkdir(_segmentsOutputDir);
+ }
+
+ public SegmentProcessorFramework(SegmentProcessorConfig
segmentProcessorConfig, File workingDir,
Review Comment:
Yes thats what I did initially :), but java's type erasure shows that the 2
constructors clash, since the have the same arguments in the same order (1st
one being List<?>). And I would really like to have 2 constructors for this, to
make the usage explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
