Jackie-Jiang commented on code in PR #10877:
URL: https://github.com/apache/pinot/pull/10877#discussion_r1224630996
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -607,24 +606,6 @@ static void
validateInstancePartitionsTypeMapConfig(TableConfig tableConfig) {
}
}
- /**
- * Detects whether both replicaGroupStrategyConfig and
replicaGroupPartitionConfig are set for a given
- * table. Validation fails because the table would ignore
replicaGroupStrategyConfig
- * when the replicaGroupPartitionConfig is already set.
- */
- @VisibleForTesting
- static void validatePartitionedReplicaGroupInstance(TableConfig tableConfig)
{
- if (tableConfig.getValidationConfig().getReplicaGroupStrategyConfig() ==
null
- || MapUtils.isEmpty(tableConfig.getInstanceAssignmentConfigMap())) {
- return;
- }
- for (Map.Entry<String, InstanceAssignmentConfig> entry:
tableConfig.getInstanceAssignmentConfigMap().entrySet()) {
- boolean isNullReplicaGroupPartitionConfig =
entry.getValue().getReplicaGroupPartitionConfig() == null;
- Preconditions.checkState(isNullReplicaGroupPartitionConfig,
Review Comment:
After a second thought, I think we can probably keep it since the validation
is applied only when a new table config is uploaded. I found this issue because
one table config in the quick start fails this validation, but I can modify the
table config to use the new config instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
