ankitsultana commented on code in PR #10971:
URL: https://github.com/apache/pinot/pull/10971#discussion_r1241037225
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/QueryDispatcher.java:
##########
@@ -85,15 +87,15 @@ public QueryDispatcher() {
}
public ResultTable submitAndReduce(long requestId, DispatchableSubPlan
dispatchableSubPlan,
- MailboxService mailboxService, long timeoutMs,
+ MailboxService mailboxService, OpChainSchedulerService scheduler, long
timeoutMs,
Map<String, String> queryOptions, Map<Integer, ExecutionStatsAggregator>
executionStatsAggregator,
boolean traceEnabled)
throws Exception {
try {
// submit all the distributed stages.
int reduceStageId = submit(requestId, dispatchableSubPlan, timeoutMs,
queryOptions);
// run reduce stage and return result.
- return runReducer(requestId, dispatchableSubPlan, reduceStageId,
timeoutMs, mailboxService,
+ return runReducer(requestId, dispatchableSubPlan, reduceStageId,
timeoutMs, mailboxService, scheduler,
Review Comment:
I think it should fix the issue that we were seeing internally.
Just a side-note: it would be interesting to see how this scales for Pinot
v1 engine use-cases with high-qps. The current design there is a simple
request/response model which would likely be faster than repeatedly yielding
and processing results. We can visit this later though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
