INNOCENT-BOY commented on code in PR #10991:
URL: https://github.com/apache/pinot/pull/10991#discussion_r1248895668
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java:
##########
@@ -359,7 +364,10 @@ private void validateSchemaInternal(Schema schema) {
validateSchemaName(schema.getSchemaName());
try {
List<TableConfig> tableConfigs =
_pinotHelixResourceManager.getTableConfigsForSchema(schema.getSchemaName());
- SchemaUtils.validate(schema, tableConfigs);
+ boolean isIgnoreCase =
+
Boolean.parseBoolean(_controllerConf.getProperty(CommonConstants.Helix.ENABLE_CASE_INSENSITIVE_KEY,
Review Comment:
Thanks for your review and your suggestion. @Jackie-Jiang
I have changed to ingest directly from TableCache other than controller
config. Please take a second look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
