ankitsultana commented on code in PR #11023:
URL: https://github.com/apache/pinot/pull/11023#discussion_r1254947757
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -247,6 +247,12 @@ private BrokerResponse handleRequest(long requestId,
String query, @Nullable Sql
// find a way to split metrics in case of multiple table
String rawTableName =
TableNameBuilder.extractRawTableName(tableNames.iterator().next());
entry.getValue().setStageLevelStats(rawTableName, brokerResponseStats,
_brokerMetrics);
+
+ // Track number of queries with number of groups limit reached
+ if (brokerResponse.isNumGroupsLimitReached()) {
Review Comment:
> do we need to track exactly which table triggers the group limit? cuz the
flag is global. there's really not much a user can do with per-table insight,
correct?
+1. I think we should simply go with global metrics. Table level metrics
would be confusing if anything. We could consider adding table-level metrics
later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
