abhioncbr commented on code in PR #11052:
URL: https://github.com/apache/pinot/pull/11052#discussion_r1268052970
##########
pinot-query-planner/src/test/java/org/apache/pinot/query/QueryEnvironmentTestBase.java:
##########
@@ -202,4 +205,10 @@ public String toString() {
}
}
}
+
+ // temporary function to strip the Physical plan from the explain query plan.
+ // physical plan is present for the explain queries by default.
Review Comment:
I was going over to see how we can set the default to LOGICAL, which
requires some hacks. There are two options I can think of,
1. Maintaining `Parser.jj` copy in Pinot instead of extracting it from the
calcite.jar. The parser has the
[code](https://github.com/apache/calcite/blob/main/core/src/main/codegen/templates/Parser.jj#L1455)
for setting the default value as Physical. I tried to put a similar function
in our `parserImpls.ftl` to override the function, but it seems like `fmpp` has
no such overriding functionality, and copying both methods failed while
generating a parser class file.
2. Before Parsing the `Explain` SQL query, check whether the `with` option
is provided. If not, add `WITHOUT IMPLEMENTATION` in the query.
Please suggest a preferable option you have in mind or among the above two.
I will try to dig more if I can get some other trick. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
