saurabhd336 commented on code in PR #11132:
URL: https://github.com/apache/pinot/pull/11132#discussion_r1270323609
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/LLCSegmentCompletionHandlers.java:
##########
@@ -448,8 +448,13 @@ private static File
extractSegmentFromFormToLocalTempFile(FormDataMultiPart form
"Invalid multi-part for segment: %s", segmentName);
FormDataBodyPart bodyPart = map.values().iterator().next().get(0);
- File localTempFile = new
File(ControllerFilePathProvider.getInstance().getFileUploadTempDir(),
- getTempSegmentFileName(segmentName));
+ File fileUploadTempDir =
ControllerFilePathProvider.getInstance().getFileUploadTempDir();
+ File localTempFile = new File(fileUploadTempDir,
getTempSegmentFileName(segmentName));
+
+ if
(!localTempFile.getCanonicalPath().startsWith(fileUploadTempDir.getPath())) {
+ throw new IllegalArgumentException("Invalid segment name: " +
segmentName);
+ }
Review Comment:
Makes sense. Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
