xiangfu0 commented on code in PR #11156:
URL: https://github.com/apache/pinot/pull/11156#discussion_r1271882974
##########
.github/workflows/scripts/.pinot_compatibility_verifier.sh:
##########
@@ -61,12 +61,12 @@ echo "</settings>">> ${SETTINGS_FILE}
# PINOT_MAVEN_OPTS is used to provide additional maven options to the
checkoutAndBuild.sh command
export PINOT_MAVEN_OPTS="-s $(pwd)/${SETTINGS_FILE}"
-if [ -z "$newerCommit" ]; then
- echo "Running compatibility regression test against \"${olderCommit}\""
+if [ -z "${NEW_COMMIT}" ]; then
+ echo "Running compatibility regression test against \"${OLD_COMMIT}\""
compatibility-verifier/checkoutAndBuild.sh -w $WORKING_DIR -o $OLD_COMMIT
else
- echo "Running compatibility regression test against \"${olderCommit}\" and
\"${newerCommit}\""
- compatibility-verifier/checkoutAndBuild.sh -w $WORKING_DIR -o $OLD_COMMIT -n
$NEW_OLD_COMMIT
+ echo "Running compatibility regression test against \"${OLD_COMMIT}\" and
\"${NEW_COMMIT}\""
+ compatibility-verifier/checkoutAndBuild.sh -w $WORKING_DIR -o $OLD_COMMIT -n
$NEW_COMMIT
Review Comment:
Interesting, this has been here for a long while
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
