xiangfu0 commented on code in PR #11144:
URL: https://github.com/apache/pinot/pull/11144#discussion_r1273190884
##########
pinot-core/src/main/java/org/apache/pinot/core/common/IntermediateStageBlockValSet.java:
##########
@@ -80,37 +83,37 @@ public int[] getDictionaryIdsSV() {
@Override
public int[] getIntValuesSV() {
- return DataBlockUtils.extractIntValuesForColumn(_dataBlock, _index);
+ return DataBlockUtils.extractIntValuesForColumn(_dataBlock, _colIndex,
_filterArgIdx);
Review Comment:
Feeling shouldn't use these many if-else checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
