Jackie-Jiang commented on code in PR #11290:
URL: https://github.com/apache/pinot/pull/11290#discussion_r1287713626
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/TupleSketchIntegrationTest.java:
##########
@@ -96,7 +95,8 @@ public void testQueries(boolean useMultiStageQueryEngine)
DEFAULT_TABLE_NAME);
JsonNode jsonNode = postQuery(query);
assertTrue(jsonNode.get("resultTable").get("rows").get(0).get(0).asLong()
> 0);
-
assertEquals(jsonNode.get("resultTable").get("rows").get(0).get(1).asText().length(),
1756);
+
assertTrue((jsonNode.get("resultTable").get("rows").get(0).get(1).asText().length()
== 1740) || (
Review Comment:
This test is too brutal, and not really verify anything..
For the raw tuple sketch, we should just deserialize it and verify if it
returns the same distinct count as the first value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
