gortiz commented on code in PR #11205:
URL: https://github.com/apache/pinot/pull/11205#discussion_r1289865538
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/TransformOperator.java:
##########
@@ -86,13 +86,14 @@ protected TransferableBlock getNextBlock() {
try {
TransferableBlock block = _upstreamOperator.nextBlock();
return transform(block);
- } catch (Exception e) {
+ } catch (RuntimeException e) {
Review Comment:
I don't actually know what we want or should do here. I'm keeping the old
behavior but being more specific.
Previous code was catching `Exception` while no checked exception was thrown
here. So I assumed that even older code was throwing a checked exception. Now
that only runtime exceptions are thrown I think it is better to explicitly only
catch `RuntimeException`s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
