Jackie-Jiang commented on code in PR #11388:
URL: https://github.com/apache/pinot/pull/11388#discussion_r1299273057
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/ExtractTransformFunction.java:
##########
@@ -84,6 +88,14 @@ private void convert(long[] timestamps, int numDocs, int[]
output) {
accessor = _chronology.dayOfMonth();
output[i] = accessor.get(timestamps[i]);
break;
+ case DOW:
+ accessor = _chronology.dayOfWeek();
+ output[i] = accessor.get(timestamps[i]);
+ break;
+ case DOY:
+ accessor = _chronology.dayOfYear();
+ output[i] = accessor.get(timestamps[i]);
+ break;
Review Comment:
```suggestion
case DOY:
accessor = _chronology.dayOfYear();
output[i] = accessor.get(timestamps[i]);
break;
case DOW:
accessor = _chronology.dayOfWeek();
output[i] = accessor.get(timestamps[i]);
break;
```
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/ExtractTransformFunction.java:
##########
@@ -36,7 +36,7 @@ public class ExtractTransformFunction extends
BaseTransformFunction {
protected Chronology _chronology = ISOChronology.getInstanceUTC();
private enum Field {
- YEAR, MONTH, DAY, HOUR, MINUTE, SECOND
+ YEAR, MONTH, DAY, DOY, DOW, HOUR, MINUTE, SECOND, QUARTER
Review Comment:
```suggestion
YEAR, QUARTER, MONTH, DAY, DOY, DOW, HOUR, MINUTE, SECOND
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
