gortiz commented on code in PR #11394:
URL: https://github.com/apache/pinot/pull/11394#discussion_r1299332664
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/MailboxService.java:
##########
@@ -45,14 +37,9 @@
public class MailboxService {
private static final Logger LOGGER =
LoggerFactory.getLogger(MailboxService.class);
private static final int DANGLING_RECEIVING_MAILBOX_EXPIRY_SECONDS = 300;
- private static final int DANGLING_EXCHANGE_EXPIRY_SECONDS = 300;
- /**
- * Cached receiving mailboxes that contains the received blocks queue.
- *
- * We use a cache to ensure the receiving mailbox are not leaked in the
cases where the corresponding OpChain is
- * either never registered or died before the sender finished sending data.
- */
+ // We use a cache to ensure the receiving mailbox are not leaked in the
cases where the corresponding OpChain is
+ // either never registered or died before the sender finished sending data.
Review Comment:
nit: Why do you use normal comments instead of javadoc here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
