Jackie-Jiang commented on code in PR #11401:
URL: https://github.com/apache/pinot/pull/11401#discussion_r1302176189


##########
pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java:
##########
@@ -63,6 +63,7 @@ public static void setMaxLinesOfStackTrace(int 
maxLinesOfStackTracePerFrame) {
   public static final int QUERY_SCHEDULING_TIMEOUT_ERROR_CODE = 240;
   public static final int EXECUTION_TIMEOUT_ERROR_CODE = 250;
   public static final int DATA_TABLE_SERIALIZATION_ERROR_CODE = 260;
+  public static final int SERVER_PARTIAL_RESPONSE_ERROR = 270;

Review Comment:
   Rename it to something like `SERVER_OVER_RESOURCE_LIMIT_ERROR`, and per the 
execution order it should be between 240 to 250 (e.g. 245)



##########
pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java:
##########
@@ -132,6 +133,8 @@ public static void setMaxLinesOfStackTrace(int 
maxLinesOfStackTracePerFrame) {
   public static final ProcessingException QUOTA_EXCEEDED_ERROR = new 
ProcessingException(TOO_MANY_REQUESTS_ERROR_CODE);
   public static final ProcessingException BROKER_REQUEST_SEND_ERROR =
       new ProcessingException(BROKER_REQUEST_SEND_ERROR_CODE);
+  private static final ProcessingException PARTIAL_RESPONSE_ERROR =

Review Comment:
   `public`? Also keep the order consistent with the error code



##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/JoinNode.java:
##########
@@ -46,12 +49,18 @@ public JoinNode(int planFragmentId) {
 
   public JoinNode(int planFragmentId, DataSchema dataSchema, DataSchema 
leftSchema, DataSchema rightSchema,

Review Comment:
   Annotate with `VisibleForTesting`



##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/AbstractPlanNode.java:
##########
@@ -94,6 +94,9 @@ public NodeHint() {
 
     public NodeHint(List<RelHint> relHints) {
       _hintOptions = new HashMap<>();
+      if (relHints == null) {

Review Comment:
   Will this ever happen? If so, annotate the parameter



##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java:
##########
@@ -228,6 +305,13 @@ private TransferableBlock 
buildJoinedDataBlock(TransferableBlock leftBlock)
     return new TransferableBlock(rows, _resultSchema, DataBlock.Type.ROW);
   }
 
+  private TransferableBlock setPartialResultExceptionToBlock(TransferableBlock 
block) {

Review Comment:
   Can you check if we read exception from the data block and EOS block? I feel 
they are just ignored



##########
pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java:
##########
@@ -163,6 +166,7 @@ public static void setMaxLinesOfStackTrace(int 
maxLinesOfStackTracePerFrame) {
     UNKNOWN_COLUMN_ERROR.setMessage("UnknownColumnError");
     UNKNOWN_ERROR.setMessage("UnknownError");
     QUOTA_EXCEEDED_ERROR.setMessage("QuotaExceededError");
+    PARTIAL_RESPONSE_ERROR.setMessage("PartialResponseError");

Review Comment:
   Keep the order consistent



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to