Jackie-Jiang commented on code in PR #11417:
URL: https://github.com/apache/pinot/pull/11417#discussion_r1307613837
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java:
##########
@@ -648,7 +671,7 @@ public Schema build() {
} catch (Exception e) {
throw new RuntimeException("Invalid schema", e);
}
- return _schema;
+ return new Schema(_schema);
Review Comment:
Is this related? Why do we want to do a swallow copy?
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java:
##########
@@ -104,7 +104,7 @@ public QueryEnvironment(TypeFactory typeFactory,
CalciteSchema rootSchema, Worke
// catalog
Properties catalogReaderConfigProperties = new Properties();
-
catalogReaderConfigProperties.setProperty(CalciteConnectionProperty.CASE_SENSITIVE.camelName(),
"true");
+
catalogReaderConfigProperties.setProperty(CalciteConnectionProperty.CASE_SENSITIVE.camelName(),
"false");
Review Comment:
Consider passing `caseInsensitive` from `BaseBrokerStarter` or reading
config `CommonConstants.Helix.ENABLE_CASE_INSENSITIVE_KEY` because case
sensitivity is configurable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
