wirybeaver commented on code in PR #10815:
URL: https://github.com/apache/pinot/pull/10815#discussion_r1323877297
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ValidationMetrics.java:
##########
@@ -239,6 +239,14 @@ public void cleanupSegmentCountGauge(final String
resource) {
removeGauge(resource, ValidationMetricName.SEGMENT_COUNT);
}
+ public void updateTmpSegmentCountGauge(final String resource, final long
tmpSegmentCount) {
Review Comment:
```
public static <T> PinotGauge<T> makeGauge(PinotMetricsRegistry registry,
PinotMetricName name, PinotGauge<T> gauge) {
return registry.newGauge(name, gauge);
}
public static PinotMeter makePinotMeter(PinotMetricsRegistry registry,
PinotMetricName name, String eventType,
TimeUnit unit) {
return registry.newMeter(name, eventType, unit);
}
```
Meter metrics would output .m1, .m5, .m15 I am not whether we need those
statics. Existing count related metrics of ValidationMetrics also use gauge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
