snleee commented on code in PR #11581:
URL: https://github.com/apache/pinot/pull/11581#discussion_r1323886100
##########
pinot-plugins/pinot-input-format/pinot-csv/src/test/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReaderTest.java:
##########
@@ -538,8 +538,9 @@ private List<GenericRow> readCSVRecords(File dataFile,
CSVRecordReaderConfig rea
try (CSVRecordReader recordReader = new CSVRecordReader()) {
recordReader.init(dataFile, null, readerConfig);
+ GenericRow reuse = new GenericRow();
while (recordReader.hasNext()) {
- GenericRow genericRow = recordReader.next();
+ GenericRow genericRow = recordReader.next(reuse);
Review Comment:
It would be great if we test both `next()` and `next(reuse)` (the main
function can use `reuse` but we should cover next() in at least one of the test
function). Is it already the case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
