klsince opened a new pull request, #11628: URL: https://github.com/apache/pinot/pull/11628
This PR adds more checks when assigning new segments for upsert table, in order to process queries correctly. The extra checks make sure that at any time the idealState has all segments from the same table partition hosted on same server. Basically, it honors the assignment in the current idealState over the one as calculated by InstancePartition. The segment is assigned according to InstancePartition, which can be ahead of IdealState if table rebalance fails to update idealState completely according to the new InstancePartition or is in middle of updating the idealState. If the new segment assignment is simply set in IdealState as done today, it's possible new segments from the same partition start to go to new server, causing queries to return wrong results.The new checks added here avoid such issue by checking if the assignment in the current idealState for the table partition is same as the one calculated from InstancePartition and favor the idealState if mismatch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
