walterddr commented on code in PR #11258:
URL: https://github.com/apache/pinot/pull/11258#discussion_r1333290379
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeFunctions.java:
##########
@@ -491,7 +492,7 @@ public static String[] toDateTimeMV(long[] millis, String
pattern, String timezo
* Converts DateTime string represented by pattern to epoch millis
*/
@ScalarFunction
- public static long fromDateTime(String dateTimeString, String pattern) {
+ public static long fromDateTime(@Nullable String dateTimeString, String
pattern) {
Review Comment:
good point, i think i mixed null and malformed handling , let's only target
malformed string in this PR. i am not sure whether we should allow null in
dateTimeString functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
