dang-stripe commented on code in PR #11650:
URL: https://github.com/apache/pinot/pull/11650#discussion_r1333452897
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/name/SimpleSegmentNameGenerator.java:
##########
@@ -40,13 +40,14 @@ public class SimpleSegmentNameGenerator implements
SegmentNameGenerator {
private final String _segmentNamePrefix;
private final String _segmentNamePostfix;
private final boolean _appendUUIDToSegmentName;
+ private final boolean _omitTimestampsInSegmentName;
public SimpleSegmentNameGenerator(String segmentNamePrefix, @Nullable String
segmentNamePostfix) {
- this(segmentNamePrefix, segmentNamePostfix, false);
+ this(segmentNamePrefix, segmentNamePostfix, false, false);
Review Comment:
i noticed the use of this constructor for minion here:
https://github.com/apache/pinot/blob/master/pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/name/SegmentNameGeneratorFactory.java#L54-L57
but it doesn't seem like `appendUUIDToSegmentName` is threaded through there
so figured it wasn't necessary to support this one either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
