gortiz commented on code in PR #11682:
URL: https://github.com/apache/pinot/pull/11682#discussion_r1336889018
##########
pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufRecordExtractor.java:
##########
@@ -54,7 +54,7 @@ public void init(@Nullable Set<String> fields,
RecordExtractorConfig recordExtra
}
private Object getFieldValue(Descriptors.FieldDescriptor fieldDescriptor,
Message message) {
- if (fieldDescriptor.isRepeated() || !fieldDescriptor.hasOptionalKeyword()
|| message.hasField(fieldDescriptor)) {
+ if (fieldDescriptor.isRepeated() || !fieldDescriptor.isOptional() ||
message.hasField(fieldDescriptor)) {
Review Comment:
Are strings and bytes marked as isRepeated by default? Reading the proto
documentation it seems we cannot distinguish between null and empty value in
strings and bytes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
