walterddr commented on PR #11686: URL: https://github.com/apache/pinot/pull/11686#issuecomment-1736555918
This is a draft to just try if we can support it and let's discuss: > The signature should be: `lookup(tableName(CHARACTER), columnName(CHARACTER), joinKey(CHARACTER), joinValue(ANY), [joinKey2(CHARACTER), joinValue2(ANY)]...)` - optional ordinal has to be added as ordinal > 4 but there's no check against only even number of args are supported - signature should have a way to infinitely support as many args, but i would say for the first version I am only planning to add 3 (similar to `caseWhen`) > can you enable some tests for both v1/v2? yes, i think we can enable selection only but anything more than that is probably not possible. - [yes] selection only - [possible] selection then group-by (as group key) - [no] selection then group-by/agg (as agg arg) - [no] used in filter ^ please let me know if I missed any test cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
