Jackie-Jiang commented on code in PR #11694:
URL: https://github.com/apache/pinot/pull/11694#discussion_r1338143446
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BaseTableUpsertMetadataManager.java:
##########
@@ -162,12 +162,14 @@ private void preloadSegments()
LOGGER.info("Preload segments from table: {} for fast upsert metadata
recovery", _tableNameWithType);
onPreloadStart();
IdealState idealState = HelixHelper.getTableIdealState(_helixManager,
_tableNameWithType);
+ Preconditions.checkState(idealState != null, "Failed to find ideal state
for table: %s", _tableNameWithType);
Review Comment:
It will print NPE without exception message, which is not as explicit as
`Failed to find ideal state...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
