Jackie-Jiang commented on code in PR #11726:
URL: https://github.com/apache/pinot/pull/11726#discussion_r1344482512
##########
pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java:
##########
@@ -70,25 +70,27 @@ public enum TransformFunctionType {
// predicate functions
EQUALS("equals"),
- NOT_EQUALS("not_equals"),
- GREATER_THAN("greater_than"),
- GREATER_THAN_OR_EQUAL("greater_than_or_equal"),
+ NOT_EQUALS("not_equals", "notEquals"),
Review Comment:
This is not the correct way to decide whether to add them though. Eventually
we need scalar function for all of them, but that is orthogonal to this problem.
Does postgreSQL support these functions? If so, we need to add them, if not,
we should not add them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
