gortiz commented on issue #11656: URL: https://github.com/apache/pinot/issues/11656#issuecomment-1746296017
All issues have been fixed in #11672, including the optional ones. Right now that PR multiplies the executions by two because they run all tests with and without the alternative buffer library. One execution always use the alternative library and the other uses bytebuffers in case the requested buffer is smaller than 2GBs. In the current code, there are some tests that fail in scenarios where Java 11 is used and bytebuffers are skipped. This is the only scenario where LArray is used. That means that LArray doesn't behaves as expected. We should fix that, but it is not related to Java 21 migration. The good news is that the Unsafe buffer library used in Java 17 and 21 pass all the tests. I consider this is ready to review. We should decide what to do with Spark (see #11701) and also which combinations do we want to test in our pipelines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
