walterddr commented on code in PR #11753:
URL: https://github.com/apache/pinot/pull/11753#discussion_r1348837924
##########
pom.xml:
##########
@@ -168,7 +168,7 @@
<argLine>-Xms4g -Xmx4g</argLine>
<protobuf.version>3.24.3</protobuf.version>
<grpc.version>1.53.0</grpc.version>
- <confluent.version>5.5.3</confluent.version>
+ <confluent.version>7.4.0</confluent.version>
Review Comment:
only use pinot-protobuf and pinot-confluent-arvo. as long as we make sure
the 2 input-format plugin works normally we should be good
##########
pom.xml:
##########
@@ -1227,6 +1232,11 @@
<artifactId>grpc-stub</artifactId>
<version>${grpc.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.google.api.grpc</groupId>
+ <artifactId>proto-google-common-protos</artifactId>
+ <version>2.9.6</version>
Review Comment:
not an expert, but can we simply shade the one used in the 2 confluent
input-format pom only?
##########
pinot-plugins/pinot-file-system/pinot-gcs/pom.xml:
##########
@@ -82,7 +82,6 @@
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-common-protos</artifactId>
- <version>1.18.1</version>
Review Comment:
this one also means the pinot-gcs file system has upgrade to 2.9.6 from
1.18.1? (this is a major version bump, worth more testing)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
