Jackie-Jiang commented on code in PR #11820:
URL: https://github.com/apache/pinot/pull/11820#discussion_r1364538222
##########
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/controller/PinotControllerTransport.java:
##########
@@ -131,6 +131,7 @@ public ControllerTenantBrokerResponse
getBrokersFromController(String controller
_headers.forEach((k, v) -> requestBuilder.addHeader(k, v));
}
+
Review Comment:
(minor) extra empty line
##########
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/base/AbstractBaseConnection.java:
##########
@@ -51,7 +51,7 @@ public void abort(Executor executor)
@Override
public void clearWarnings()
throws SQLException {
- throw new SQLFeatureNotSupportedException();
+ // no-op
Review Comment:
This seems unrelated to this PR. Can you open a separate PR for these
changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
