ege-st commented on code in PR #11776:
URL: https://github.com/apache/pinot/pull/11776#discussion_r1366021711
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/converter/RealtimeSegmentConverter.java:
##########
@@ -70,11 +72,27 @@ public RealtimeSegmentConverter(MutableSegmentImpl
realtimeSegment, SegmentZKPro
_tableConfig = tableConfig;
_segmentName = segmentName;
_nullHandlingEnabled = nullHandlingEnabled;
+
+ // Check if column major mode should be enabled
+ try {
+ // TODO(Erich): move this so that the code does not directly reference
the flag name
Review Comment:
Fixed this. is using the deprecated config structure for their tables (from
the sample I got) and this is for the new stream config. To make migration
simple I added a field for both the old and new configuration methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
