xiangfu0 commented on code in PR #11839:
URL: https://github.com/apache/pinot/pull/11839#discussion_r1367374843
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeConvert.java:
##########
@@ -35,7 +36,7 @@ public class DateTimeConvert {
private DateTimeGranularitySpec _granularitySpec;
@ScalarFunction(names = {"dateTimeConvert", "date_time_convert"})
- public String dateTimeConvert(String timeValueStr, String inputFormatStr,
String outputFormatStr,
+ public Object dateTimeConvert(String timeValueStr, String inputFormatStr,
String outputFormatStr,
Review Comment:
there is a type inference here:
https://github.com/apache/pinot/blob/master/pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java#L125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
