walterddr commented on PR #11831: URL: https://github.com/apache/pinot/pull/11831#issuecomment-1775767838
Note to self: Exchange elimination cannot be done in this rule. it has to be done after the RelDistribution has propagated all the way through. then a top-down (instead of bottom-up) rule needs to apply to eliminate exchange in a - (RelNode -> Exchange -> RelNode) fashion for singleRel - (RelNode -> left/right Exchange -> left/right RelNode) fashion for joins otherwise the exchange elimination is done with not enough info and can cause join to not function properly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
