Jackie-Jiang commented on code in PR #11824:
URL: https://github.com/apache/pinot/pull/11824#discussion_r1381222882
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/type/TypeFactory.java:
##########
@@ -52,13 +52,24 @@ public RelDataType createRelDataTypeFromSchema(Schema
schema) {
}
private RelDataType toRelDataType(FieldSpec fieldSpec) {
+ RelDataType type = createSqlType(getSqlTypeName(fieldSpec));
+ boolean isArray = !fieldSpec.isSingleValueField();
+ if (isArray) {
+ type = createArrayType(type, -1);
+ }
+ boolean isNullable = fieldSpec.getNullable() != null &&
fieldSpec.getNullable();
Review Comment:
This is the query path (registering for multi-stage engine) I was referring
to, which doesn't check the table config. IMO this is the correct way to keep
backward compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
