Jackie-Jiang commented on code in PR #11857:
URL: https://github.com/apache/pinot/pull/11857#discussion_r1384225641
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/V1Constants.java:
##########
@@ -44,14 +44,17 @@ public static class Indexes {
public static final String UNSORTED_MV_FORWARD_INDEX_FILE_EXTENSION =
".mv.fwd";
public static final String BITMAP_INVERTED_INDEX_FILE_EXTENSION =
".bitmap.inv";
public static final String BITMAP_RANGE_INDEX_FILE_EXTENSION =
".bitmap.range";
- public static final String FST_INDEX_FILE_EXTENSION = ".lucene.fst";
public static final String JSON_INDEX_FILE_EXTENSION = ".json.idx";
public static final String NATIVE_TEXT_INDEX_FILE_EXTENSION =
".nativetext.idx";
public static final String H3_INDEX_FILE_EXTENSION = ".h3.idx";
public static final String BLOOM_FILTER_FILE_EXTENSION = ".bloom";
public static final String NULLVALUE_VECTOR_FILE_EXTENSION =
".bitmap.nullvalue";
+ public static final String LUCENE_FST_INDEX_FILE_EXTENSION = ".lucene.fst";
public static final String LUCENE_TEXT_INDEX_DOCID_MAPPING_FILE_EXTENSION
= ".lucene.mapping";
public static final String LUCENE_TEXT_INDEX_FILE_EXTENSION =
".lucene.index";
+ public static final String LUCENE_V9_FST_INDEX_FILE_EXTENSION =
".lucene.v9.fst";
+ public static final String
LUCENE_V9_TEXT_INDEX_DOCID_MAPPING_FILE_EXTENSION = ".lucene.v9.mapping";
Review Comment:
Going through the code, and seems we don't need a V9 version of this doc id
mapping file. This is created locally at server, and the format doesn't change
across versions. When we upgrade the version, we should be able to reuse the
mapping file from the old version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]